C1 SNICAR-AD Shortwave Radiation for Sea Ice and Land

Jun 17, 2019

This page is a main, parent documentation page for this feature. The tables below provide links to all related documentation on this feature. 

 The page consists of two tables... Click here to read more about the tables...

The first Dependencies Table provides information on features dependencies, lists expected Pull Request (PR) date (expected time this feature will be ready for integration), it also lists all the other known new code features that are blocking completion of this code. It lists all known features that depend on this feature being integrated. It also provides the date the PR was actually issued, the name of the integrator, the date the code was integrated and a hash/tag of the code integration into the ACME git repository. The information from this table feeds the overview table in the New Features Dependencies Overview page which is meant to be used by integrators to check the priority order in which the features should be integrated. It also provides an overview of all the new features and the expected integration dates. 

The second Checklist Table lists the code review steps to be taken in order. As you work on integrating your feature into ACME code, step along the Checklist table on your main page, obtain the approvals before going to the next step. For the phase 1 review, the Group Leads are the approvers, they can decide to sign on on the documentation or a verification step even if it is not completely finished, especially for the grandfathered features. The relevant documentation page does have to be created though and the explanation needs to be provided in Summary section as to why it is approved, what is the basis for approval. For example is there were tests performed on related feature and they proved indirectly that this feature works as expected, then the approver needs to document that. 

The Design Document page provides a description of the algorithms, implementation and planned testing including unit, verification, validation and performance testing. 

The Verification and Unit Testing page provides the short information and links to the tests that were performed, together with the links to the runs, their provenance and their results. The same information is called for in The Performance Assessment page and The Validation page in phase 1 of code review process. 

Dependencies Table for this feature

1.Design DocC1 SNICAR-AD Shortwave Radiation for Sea Ice and Land
2.OwnerCheng Dang (Unlicensed)
3.PR Ready 
4.Blocked By#None
5.Affects #C2 Snow-On-Seaice improvements
PR Approved ByStephen Price
Date Approved
6.Issued PR

https://github.com/MPAS-Dev/MPAS-Model/pull/63 into MPAS_Dev

https://github.com/MPAS-Dev/MPAS-Model/pull/278 into MPAS_Dev

https://github.com/E3SM-Project/E3SM/pull/2975 into E3SM:master

https://github.com/E3SM-Project/E3SM/pull/3058

7.PR AssigneeJon Wolfe for 3058,  Junqi Yin (Unlicensed) for 2975
8.Integrated  for 2975   for 3058
9.Hash/Tag23b872b for 3058
10.Git Branch

jonbob/seaice/update-snow-snicar for 3058



Checklist for the Code Review Process for this feature

Action RequiredAssignee - Task OwnerLinkDone ?Done DateApproved?ApproverApproved DateNotes
Phase 1 - Component Level Development and Testing
Design Document

Cheng Dang (Unlicensed)

and Charlie Zender

C1 SNICAR-AD Shortwave Radiation for Sea Ice and Land Design Document

(tick)Jun 17, 2019

(tick)


Stephen Price7-8-19
Verification and Unit TestsCheng Dang (Unlicensed)

C1 SNICAR-AD Shortwave Radiation for Sea Ice and Land Verification Phase 1


(tick)Jun 17, 2019(tick)Stephen Price7-8-19
Performance AssessmentCheng Dang (Unlicensed)

The new implementation is not expected to have a significant impact on the computational cost/performance of E3SM.

(tick)Jun 17, 2019(tick)Stephen Price7-8-19
Validation TestsCheng Dang (Unlicensed)

C1 SNICAR-AD Shortwave Radiation for Sea Ice and Land Validation Phase 1 

(tick)Jun 17, 2019(tick)Stephen Price7-8-19
Issue Pull RequestCheng Dang (Unlicensed)

SNICAR-AD in MPAS-seaice: https://github.com/MPAS-Dev/MPAS-Model/pull/63https://github.com/MPAS-Dev/MPAS-Model/pull/278

SNICAR-AD in ELM: https://github.com/E3SM-Project/E3SM/pull/2975

(tick)Jun 17, 2019(tick)Stephen Price7-8-19
PR Integratorassigned integrator-
integrated date----
Phase 2 - Coupled System Integration and Testing
Phase 2 Process Doc


(error)(error)

Feature's Coupled Performance

(error)(error)


Feature's Coupled Validation

(error)(error)


Final Approval to part of ACME model
(error)----