Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.
Expand
titleThe page consists of two tables... Click here to read more about the tables...

The first Dependencies Table provides information on features dependencies, lists expected Pull Request (PR) date (expected time this feature will be ready for integration), it also lists all the other known new code features that are blocking completion of this code. It lists all known features that depend on this feature being integrated. It also provides the date the PR was actually issued, the name of the integrator, the date the code was integrated and a hash/tag of the code integration into the ACME git repository. The information from this table feeds the overview table in the New Features Dependencies Overview page which is meant to be used by integrators to check the priority order in which the features should be integrated. It also provides an overview of all the new features and the expected integration dates. 

The second Checklist Table lists the code review steps to be taken in order. As you work on integrating your feature into ACME code, step along the Checklist table on your main page, obtain the approvals before going to the next step. For the phase 1 review, the Group Leads are the approvers, they can decide to sign on on the documentation or a verification step even if it is not completely finished, especially for the grandfathered features. The relevant documentation page does have to be created though and the explanation needs to be provided in Summary section as to why it is approved, what is the basis for approval. For example is there were tests performed on related feature and they proved indirectly that this feature works as expected, then the approver needs to document that. 

The Design Document page provides a description of the algorithms, implementation and planned testing including unit, verification, validation and performance testing. 

The Verification and Unit Testing page provides the short information and links to the tests that were performed, together with the links to the runs, their provenance and their results. The same information is called for in The Performance Assessment page and The Validation page in phase 1 of code review process. 

Page Properties
idfeature

Dependencies Table for this feature

1.Design Doc
2.Owner
3.PR Ready
4.Blocked By#
5.Affects #
6.Issued PR
7.PR Owner
8.Integrated
9.Hash/Tag


HTML Comment

Labels to choose from for the 'Done ?' and 'Approved ?' columns

(tick) - competed, (warning) - in progress, (error) - not done/not started


Checklist for the Code Review Process for this feature

Action RequiredAssignee - Task OwnerLinkDone ?Done DateApproved?ApproverApproved DateNotes
Phase 1 - Component Level Development and Testing
Design Document

(error)

 

(error)

Verification and Unit Tests(error)(error)   
Performance Assessment(error)(error)   
Validation Tests(error)(error)   
Issue Pull Request(error)(error)   
PR Integratorassigned integrator- integrated date----
Phase 2 - Coupled System Integration and Testing
Phase 2 Process Doc(error)(error)  
Feature's Coupled Performance(error)(error)   
Feature's Coupled Validation(error)(error)   
Final Approval to part of ACME model (error)----









The Design Document page provides a description of the algorithms, implementation and planned testing including unit, verification, validation and performance testing. Please read  Step 1.3 Performance Expectations that explains feature documentation requirements from the performance group point of view. 

Design Document

HTML Comment

(tick) - competed, (warning) - in progress, (error) - not done

Page Properties
idFeature_PR
Info

Overview table for the owner and an approver of this feature

1.Name

CLUBBe convective configuration (CLUBB as shallow and turbulence) + MG2 microphysics
2.OwnerWuyin Lin
3.Created
4.Equ(error)
5.Ver(error)
6.Perf(error)
7.Val(error)
8.Approver
9.Approved Date
Expand
titleClick here for Table of Contents ...
Panel

Table of Contents

Table of Contents

 

Title: Some descriptive title

Requirements and Design

ACME  Group

Date:  

Summary

The purpose of this section is to summarize what capability is to be added to the ACME Ocean and Ice system through this design process. It should be clear what new code will do that the current code does not. Summarizing the primary challenges with respect to software design and implementation is also appropriate for this section. Finally, this statement should contain general statement with regard to what is “success.”

 

Requirements

Requirement: name-of-requirement-here

Date last modified:  
Contributors:  (add your name to this list if it does not appear)


Each requirement is to be listed under a ”section” heading, as there will be a one-to-one correspondence between requirements, design, proposed imple- mentation and testing. Requirements should not discuss technical software issues, but rather focus on model capability. To the extent possible, require- ments should be relatively independent of each other, thus allowing a clean design solution, implementation and testing plan.

 

Algorithmic Formulations

Design solution: short-description-of-proposed-solution-here

Date last modified:
Contributors: (add your name to this list if it does not appear)

 

For each requirement, there is a design solution that is intended to meet that requirement. Design solutions can include detailed technical discussions of PDEs, algorithms, solvers and similar, as well as technical discussion of performance issues. In general, this section should steer away from a detailed discussion of low-level software issues such as variable declarations, interfaces and sequencing.

 

Design and Implementation

Implementation: short-desciption-of-implementation-here

Date last modified: 
Contributors: (add your name to this list if it does not appear)

 

This section should detail the plan for implementing the design solution for requirement XXX. In general, this section is software-centric with a focus on software implementation. Pseudo code is appropriate in this section. Links to actual source code are appropriate. Project management items, such as svn branches, timelines and staffing are also appropriate. How do we typeset pseudo code?

 

Planned Verification and Unit Testing 

Verification and Unit Testing: short-desciption-of-testing-here

Date last modified:  
Contributors: (add your name to this list if it does not appear)

 

How will XXX be tested? i.e. how will be we know when we have met requirement XXX. Will these unit tests be included in the ongoing going forward?

Planned Validation Testing 

Validation Testing: short-desciption-of-testing-here

Date last modified:
Contributors: (add your name to this list if it does not appear)

 

How will XXX be tested? What observational or other dataset will be used?  i.e. how will be we know when we have met requirement XXX. Will these unit tests be included in the ongoing going forward?

Planned Performance Testing 

Performance Testing: short-desciption-of-testing-here

Date last modified:
Contributors: (add your name to this list if it does not appear)

 

How will XXX be tested? i.e. how will be we know when we have met requirement XXX. Will these unit tests be included in the ongoing going forward?