Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

This document provides details on ACME development conventions and practices.

...

important -- Items colored in red mean they are important, and should not be ignored.

one time -- Items colored in green are commands to be issued once per machine.

repo once -- Items colored in orange are commands to be issued once per local repository.

...

Your PR is not finished until it has been merged to master by the Integrator.


This document can be used to help with pull request related issues.

...

After a reviewer is satisfied with all parts of a pull request, both the reviewer and the developer will perform testing on the pull request. The developer may be required to point a reviewer to a specific test case or namelist that can help the reviewer test the feature.

In addition to testing the feature, it is the reviewers responsibility to verify the pull request does not introduce issues related to the previous functionality of master.  To ensure that the model still passes basic tests in multiple configurations, developers will be asked to run the acme_developer test suite.  This can either be performed on the branch itself, or in an integration branch. The reviewer will inform the developer where testing should take place.

 See /wiki/spaces/SE/pages/7998600 for instructions on Basic instructions for running the acme_developer test suite can be found at Testing.  Some additional information on testing procedures can be found at at /wiki/spaces/SE/pages/7998600 and /wiki/spaces/SE/pages/3244819.  Results from nightly test suites run on the "next" and "master" branches can be viewed on the ACME CDash website.
 

...

Before communicating with remotes, you might want to add or remove remotes. In order to add and remove remotes the git remote command can be used. The two uses are as follows:

git remote add remote-name protocol:address/to/repo # Creates a remote

 

git remote remove remote-name # Removes a remote

  

In order to communicate with remotes, there are three actions. pushpull, and fetch.

...