Versions Compared

Old Version 2

changes.mady.by.user Andy Salinger

Saved on

compared with

New Version 3

changes.mady.by.user Doug Jacobsen

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

  1. Code development should begin from the master branch or most recent release branch of ACME from the github repository, and take place on a feature branch
  2. Code should of high enough quality to be readable, modifiable, and maintainable by others
  3. For eventual inclusion in the ACME model, the development should document the main steps of the ACME Code Review process:
    1. A design document (or paper) detailing the equations/algorithms that are being implemented
    2. Verification evidence that supports that the implementation is correct
    3. One or more tests added to the ACME testing system to protect the new feature against future developments
    4. Performance analysis and data showing the expected and measured performance impact of the new feature
    5. Validation evidence that the feature matches observational data
  4. Code development should be incorporated into, or rebased fromonto, the ACME code base every few months, and developers must verify that the ACME tests still pass on this development branch (ACME has no resources to reconcile code that has been on diverging development paths for a year or more).

...