Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

Current ELM irrigation scheme assumes surface water demand is always met and ignores the surface water constraints at short time scales, leading to overestimation of surface water usage, underestimation of groundwater pumping, and unrealistic simulation of their seasonal variability. With two-way coupling, surface water irrigation is constrained by the available runoff, streamflow, and reservoir storage simulated in MOSART.


Requirements

Requirement: Coupling irrigation water withdrawal between ELM and MOSART

Date last modified:  
Contributors: Anthony CraigGuoyong Leng (Unlicensed)Tian Zhou


Each requirement is to be listed under a ”section” heading, as there will be a one-to-one correspondence between requirements, design, proposed imple- mentation and testing. Requirements should not discuss technical software issues, but rather focus on model capability. To the extent possible, require- ments should be relatively independent of each other, thus allowing a clean design solution, implementation and testing plan.


Algorithmic Formulations

Design solution:

short-description-of-proposed-solution-here

At each coupling time step, following steps will be performed: 1) ELM evaluates the soil moisture deficits and determines the irrigation demand at grid level. 2) The irrigation demand will be split into surface water and groundwater irrigation demand based on a predefined fraction. 3) The surface water demand will be sent to MOSART through coupler. 4) MOSART determines the irrigation supply based on the local runoff, streamflow, and upstream reservoir storage. 5) Irrigation supply will be sent back to ELM through the coupler. 6) ELM applies irrigation which is the sum of  the surface water irrigation supply from MOSART and groundwater irrigation which is assumed always met.   

Date last modified:

// date

  
Contributors: Anthony Craig, 

(add your name to this list if it does not appear)For each requirement, there is a design solution that is intended to meet that requirement. Design solutions can include detailed technical discussions of PDEs, algorithms, solvers and similar, as well as technical discussion of performance issues. In general, this section should steer away from a detailed discussion of low-level software issues such as variable declarations, interfaces and sequencing

Guoyong Leng (Unlicensed)Tian Zhou.


Design and Implementation

Implementation:

short-desciption-of-implementation-here

Pull request about this implementation (https://github.com/E3SM-Project/E3SM/pull/3074)

Date last modified:

 // date

  
Contributors: 

(add your name to this list if it does not appear)This section should detail the plan for implementing the design solution for requirement XXX. In general, this section is software-centric with a focus on software implementation. Pseudo code is appropriate in this section. Links to actual source code are appropriate. Project management items, such as svn branches, timelines and staffing are also appropriate. How do we typeset pseudo code?

Anthony CraigTian Zhou


Planned Verification and Unit Testing 

Verification and Unit Testing:

short-desciption-of-testing-here

B4B tests passed

How will XXX be tested? i.e. how will be we know when we have met requirement XXX. Will these unit tests be included in the ongoing going forward?

Date last modified:   
Contributors: 

(add your name to this list if it does not appear)

Tian Zhou


E3SM land modeler b4b tests were performed and passed with the two-way coupling turned off. 

Planned Validation Testing 

Validation Testing:

short-desciption-of-testing-here

30 year simulations with and without two-way irrigation

Date last modified:  
Contributors: 

(add your name to this list if it does not appear)How will XXX be tested? What observational or other dataset will be used?  i.e. how will be we know when we have met requirement XXX. Will these unit tests be included in the ongoing going forward?

Tian Zhou


A set of simulation experiments were performed with different model configurations including 1-way coupled surface water irrigation only; 1-way coupled surface water and groundwater irrigation; 2-way coupled surface water irrigation only; 2-way coupled surface water and groundwater irrigation. These simulation experiments produced reasonable results. See details in Zhou et al. (submitted)

Zhou, T; L. R. Leung; G. Leng; N. Voisin; H. Li; A. P. Craig; T. Tesfa; Y. Mao (in review). Global irrigation characteristics and effects simulated by fully coupled land surface, river, and water management models in E3SM. Journal of Advances in Modeling Earth Systems

Planned Performance Testing 

Performance Testing: short-desciption-of-testing-here

Date last modified:
Contributors: (add your name to this list if it does not appear)


How will XXX be tested? i.e. how will be we know when we have met requirement XXX. Will these unit tests be included in the ongoing going forward?


...